Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http2 connection pool optimisation #2257

Closed
wants to merge 11 commits into from
Closed

Http2 connection pool optimisation #2257

wants to merge 11 commits into from

Conversation

violetagg
Copy link
Member

HTTP2 stream channel pipeline optimisation

This was referenced Jun 1, 2022
Closed
Closed
@violetagg violetagg force-pushed the http2-optimization branch from 103ae07 to bf36afc Compare June 3, 2022 12:26
violetagg added 5 commits June 6, 2022 11:17
@violetagg
Http2Pool handles the lifecycle of the cache with connections
ce97087 
Cache Http2FrameCodec/Http2MultiplexHandler context
@violetagg
Add maxIdleTime to Http2Pool
cfb70d5
@violetagg
Add evictInBackground to Http2Pool
a2aa3a5
@violetagg
Http2StreamChannelBootstrap can be shared
a6f6e1f 
Http2StreamFrameToHttpObjectCodec can be shared
Http2StreamBridgeClientHandler can be shared
@violetagg
Add scheduled flush for HTTP/2
78e7ff2
@violetagg violetagg force-pushed the http2-optimization branch from 95f9216 to 9606f19 Compare June 6, 2022 09:38
@violetagg violetagg mentioned this pull request Jun 6, 2022
Closed
@violetagg violetagg marked this pull request as ready for review June 6, 2022 09:59
@violetagg violetagg requested a review from a team June 6, 2022 09:59
@violetagg violetagg added type/bug A general bug type/enhancement A general enhancement labels Jun 6, 2022
@violetagg violetagg added this to the 1.0.20 milestone Jun 6, 2022
@violetagg violetagg force-pushed the http2-optimization branch from 9606f19 to 7885fac Compare June 6, 2022 18:16
simonbasle
simonbasle requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, though I added a few small comments

reactor-netty-core/src/main/java/reactor/netty/resources/PooledConnectionProvider.java Show resolved Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2AllocationStrategy.java Outdated Show resolved Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2AllocationStrategy.java Outdated Show resolved Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/Http2AllocationStrategy.java Outdated Show resolved Hide resolved
@violetagg
Copy link
Member Author

@reactor/netty-team I added 3 additional changes PTAL

@violetagg
Obtain the application protocol once
b536581 
Cache H2CUpgradeHandler context
pderop
pderop approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

This was linked to issues Jun 8, 2022
HTTP2 connections not used efficiently #2262
Closed
Http2 slower then http1 in high volume #2151
Open
HTTP2 - Round-robining streams across a minimum setting of connections #1808
Closed
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Http2Pool handles the lifecycle of the cache with connections (#2257)
f5e79b7 
Cache Http2FrameCodec/Http2MultiplexHandler/H2CUpgradeHandler context.
Obtain the negotiated application level protocol once.

Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Add maxIdleTime to Http2Pool (#2257)
d9ae62c 
Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Add evictInBackground to Http2Pool (#2257)
dae5de8 
Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Http2StreamChannelBootstrap can be shared (#2257)
14b2bfc 
Http2StreamFrameToHttpObjectCodec can be shared
Http2StreamBridgeClientHandler can be shared

Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Add scheduled flush for HTTP/2 (#2257)
adb991d 
Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Introduce HTTP2AllocationStrategy for specifying minConnections and m…
6530f76 
…axConcurrentStreams (#2257)

Fixes #1808
@violetagg
Copy link
Member Author

@simonbasle @pderop Thanks for the review!

violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Merge #2257 into main
a516bea
@violetagg
Copy link
Member Author

Changes were applied to 1.0.x and merged in main

@violetagg violetagg closed this Jun 8, 2022
@violetagg violetagg deleted the http2-optimization branch June 8, 2022 10:47
pderop added a commit to pderop/reactor-netty that referenced this pull request Jun 8, 2022
@pderop
merged PR reactor#2257 from 1.0.x branch.
3be34aa
violetagg added a commit that referenced this pull request Jun 14, 2022
@violetagg
Merge #2257 #2175 #2274 #2294 #2295 into netty5
e7a1551
@violetagg violetagg removed the type/bug A general bug label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.20
3 participants
@violetagg @pderop @simonbasle