Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move read request from handlerAdded to channelRegistered #2289

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Move read request from handlerAdded to channelRegistered #2289

merged 1 commit into from
Jun 14, 2022

Conversation

violetagg
Copy link
Member

Related to #1873

@violetagg violetagg added the type/enhancement A general enhancement label Jun 10, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone Jun 10, 2022
@violetagg violetagg requested a review from a team June 10, 2022 13:07
pderop
pderop approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop @simonbasle Thanks

@violetagg violetagg merged commit 87fb283 into netty5 Jun 14, 2022
@violetagg violetagg deleted the channel-registered branch June 14, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@violetagg @pderop @simonbasle