Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reactor Netty version of the Quote of the Moment example #2636

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

jchenga
Copy link
Contributor

@jchenga jchenga commented Jan 7, 2023

This PR attempts to provide a corresponding Reactor Netty version of the QOTM example available in Netty project.

Related to #761

@jchenga jchenga force-pushed the 761-quote-of-the-moment-example branch from d89a3a2 to be9f6cf Compare January 7, 2023 19:20


Provide a corresponding Reactor Netty version of the Quote of the
Moment example in the Netty project.
@jchenga jchenga force-pushed the 761-quote-of-the-moment-example branch from be9f6cf to db33022 Compare January 7, 2023 19:26
@violetagg violetagg added the type/documentation A documentation update label Jan 13, 2023
@violetagg violetagg added this to the 1.1.3 milestone Jan 13, 2023
@violetagg
Copy link
Member

@jchenga I'm gonna check this today

Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchenga Thanks for the PR!

@violetagg violetagg requested a review from a team January 16, 2023 09:17
@violetagg
Copy link
Member

@reactor/netty-team PTAL

Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the PR.

@violetagg violetagg merged commit 7055a3b into reactor:main Jan 16, 2023
@violetagg violetagg changed the title Add Reactor Netty version of the Quote of the Moment example #761 Add Reactor Netty version of the Quote of the Moment example Jan 16, 2023
violetagg added a commit that referenced this pull request Jan 16, 2023
@jchenga
Copy link
Contributor Author

jchenga commented Jan 16, 2023

@jchenga Thanks for the PR!

No problem. Glad to be of help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants