Ensure HttpServer minCompressionSize is respected when Content-Length is not explicit and response is Mono
#2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not explicit and response is Mono When a Mono is sent as a response or a single ByteBuf is sent as a response, Reactor Netty will send FullHttpResponse and thus is able to set Content-Length if such is not already set. Based on the Content-Length, Reactor Netty can decide whether or not a compression is needed.
|
@reactor/netty-team PTAL |
pderop
approved these changes
Jan 11, 2023
|
@pderop Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Jan 11, 2023
violetagg
added a commit
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Monois sent as a response or a singleByteBufis sent as a response,Reactor Nettywill sendFullHttpResponseand thus is able to setContent-Lengthif such is not already set. Based on theContent-Length,Reactor Nettycan decide whether or not a compression is needed.