Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Objects.hash() #2732

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Replace Objects.hash() #2732

merged 1 commit into from
Mar 20, 2023

Conversation

yuzawa-san
Copy link
Contributor

This call requires an Object[] allocation and does boxing on primitives, so should not be used in high performance environments.

CPU usage before:
image

CPU usage after:
image

sorry for the duplicate, wrong base branch on the first time

@yuzawa-san
Replace Objects.hash()
150e3cb 
This call requires an Object[] allocation and does boxing, so should not be used in high performance environments.
@yuzawa-san yuzawa-san mentioned this pull request Mar 19, 2023
Merged
@violetagg violetagg self-requested a review March 20, 2023 07:39
@violetagg violetagg changed the base branch from main to 1.0.x March 20, 2023 08:05
@violetagg violetagg changed the base branch from 1.0.x to main March 20, 2023 08:06
violetagg
violetagg approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reactor/netty-team PTAL

@violetagg violetagg added this to the 1.0.31 milestone Mar 20, 2023
@violetagg violetagg added the type/enhancement A general enhancement label Mar 20, 2023
@violetagg violetagg requested a review from a team March 20, 2023 08:16
pderop
pderop approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR !

LGTM

@violetagg
Copy link
Member

@yuzawa-san Thanks

@violetagg violetagg merged commit 95b215b into reactor:main Mar 20, 2023
@violetagg violetagg changed the title Replace Objects.hash() Replace Objects.hash() Mar 20, 2023
violetagg pushed a commit that referenced this pull request Mar 20, 2023
@yuzawa-san @violetagg
Replace Objects.hash() (#2732)
669ad3b 
This call requires an Object[] allocation and does boxing, so should not be used in high performance environments.
violetagg added a commit that referenced this pull request Mar 20, 2023
@violetagg
Merge #2732 into 2.0.0-M4
22c222a
@violetagg
Copy link
Member

I back ported this to version 1.0.x and also applied to netty5 branch

violetagg added a commit that referenced this pull request Mar 22, 2023
@violetagg
Replace Objects.hash()
d61625e 
This is related to PR #2732
@violetagg violetagg mentioned this pull request Mar 22, 2023
Merged
violetagg added a commit that referenced this pull request Mar 22, 2023
@violetagg
Replace Objects.hash() (#2737)
e3c3f97 
This is related to PR #2732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violetagg violetagg violetagg approved these changes

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.31
Development

Successfully merging this pull request may close these issues.
3 participants
@yuzawa-san @violetagg @pderop