Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in javadoc for allowPartialChunks setting #3471

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

andrross
Copy link
Contributor

FYI @reta, I stumbled across a typo in #3453

Signed-off-by: Andrew Ross <andrross@amazon.com>
@pivotal-cla
Copy link

@andrross Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrross Thanks for the PR!
Can you please sing the CLA?
May be we can mark this as on obvious fix? https://cla.pivotal.io/about#obvious-fix

@violetagg violetagg changed the base branch from main to 1.1.x October 17, 2024 05:43
@violetagg violetagg changed the base branch from 1.1.x to main October 17, 2024 05:44
@violetagg violetagg added the type/documentation A documentation update label Oct 17, 2024
@violetagg violetagg changed the title Fix typo in Javadoc for 'allowPartialChunks' setting Fix typo in javadoc for allowPartialChunks setting Oct 17, 2024
@violetagg violetagg added this to the 1.1.24 milestone Oct 17, 2024
@andrross
Copy link
Contributor Author

@pivotal-cla This is an Obvious Fix

@pivotal-cla
Copy link

@andrross This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@violetagg violetagg merged commit f1efa19 into reactor:main Oct 18, 2024
9 of 14 checks passed
violetagg pushed a commit that referenced this pull request Oct 18, 2024
Signed-off-by: Andrew Ross <andrross@amazon.com>
violetagg added a commit that referenced this pull request Oct 18, 2024
@violetagg
Copy link
Member

@andrross @reta I back ported the fix to 1.1.x branch

@reta
Copy link
Contributor

reta commented Oct 18, 2024

@andrross @reta I back ported the fix to 1.1.x branch

Thanks a lot!

@andrross andrross deleted the fix-typo branch October 18, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants