Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize pool warmup #171

Merged
merged 9 commits into from
Jul 9, 2023
Merged

Optimize pool warmup #171

merged 9 commits into from
Jul 9, 2023

Commits on Jun 22, 2023

  1. Optimize pool warmup

    @pderop
    pderop committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6aaf48f View commit details
    Browse the repository at this point in the history

  2. Ensure borrowers are always scheduled throw the acquisition scheduler… 

    …, if any are configured.
    @pderop
    pderop committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    dea28ba View commit details
    Browse the repository at this point in the history

  3. Polish the PoolWarmupTest

    @pderop
    pderop committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    17e0226 View commit details
    Browse the repository at this point in the history

  4. Last polishing applied to PoolWarmupTest

    @pderop
    pderop committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    4f6f4fe View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Lazy warmup must use mergeSequential to ensure that primary is comple… 

    …ted first.
    @pderop
    pderop committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3ce0667 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. - reverted delivery of borrower through the acquisition scheduler: th… 

    …is can be done in a separate PR.

- resources allocated during warmup are subscribed to eagerly, but now you can configure the level of concurrency using `PoolBuilder.warmupConcurrency(int concurrency)`
- improved the warpmupTest
    @pderop
    pderop committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    e484c26 View commit details
    Browse the repository at this point in the history

  2. Replaced PoolBuilder.warmupConcurrenty(int concurrency) method by Poo… 

    …lBuilder.parallelizeWarmup(boolean).

Warmups are not parallel (as before).
Reverted CommonPoolTest.recordsAllocationLatenciesInWarmup test, because warmup is like before, by default: no concurrency.
Improved PoolWarmupTest.
    @pderop
    pderop committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c4a5af8 View commit details
    Browse the repository at this point in the history

  3. Replace PoolBuilder.parallelizeWarmup(boolean) by PoolBuilder.sizeBet… 

    …ween(min, max, warmupParallelism).
    @pderop
    pderop committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    6b686b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Applied feedback: reverted changes done in warmupMono, and applied su… 

    …ggestion in drainloop.
    @pderop
    pderop committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c6ddf8b View commit details
    Browse the repository at this point in the history