Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAPPS-DB] Add Chromium-XP browsers 49.0.2623.113 #202

Merged
merged 7 commits into from
Oct 24, 2023
Merged

[RAPPS-DB] Add Chromium-XP browsers 49.0.2623.113 #202

merged 7 commits into from
Oct 24, 2023

Conversation

JoachimHenze
Copy link
Contributor

@JoachimHenze JoachimHenze commented Oct 20, 2023 •
edited
Loading

Prebundled with (outdated) Pepperflash 21.0.0.213.
489/555 points in html5test.com
WebM VP9 support.
Currently needs --no-sandbox command line option to run on ros (ros bug https://jira.reactos.org/browse/CORE-9272 ).
Currently suffers from the well-known "sticky-mouse-issue" in ros (ros bug https://jira.reactos.org/browse/CORE-14998 ).
Currently must be killed with the taskmgr to end its processes in ros (ros bug https://jira.reactos.org/browse/CORE-14185 ).
Currently quickly lures ros to BSOD 0x1A unless you spend a lot of RAM on it (>1GB highly recommended) (ros bug same callstack as https://jira.reactos.org/browse/CORE-18190 ).
The browser runs without any quirks on 2k3sp2 and XPSP3. It is well done, indeed outperforming the last official Chromium sources M49.0.2623.112.

Forked from the official Chromium sources M49.0.2623.112
1
2
3outdatedPepperflash
4
5sourceforge_demo
7

@JoachimHenze
[RAPPS-DB] Add Chromium-XP browsers
213d480 
Prebundled with Pepperflash 21.0.0.213.
WebM VP9 support.
489 points in html5test.com
Currently needs --no-sandbox command line option to run on ros.

Forked from the official Chromium sources M49.0.2623.112
@JoachimHenze JoachimHenze self-assigned this Oct 20, 2023
@JoachimHenze JoachimHenze changed the title [RAPPS-DB] Add Chromium-XP browsers [RAPPS-DB] Add Chromium-XP browsers 49.0.2623.113 Oct 20, 2023
This was referenced Oct 20, 2023
Closed
Open
binarymaster
binarymaster reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@binarymaster binarymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General suggestion: Maybe simplify .txt filenames, as it would complicate installing from command-line RAPPS.

Chromium-XP_49_0_2623_113-R2_VS2015_SSE2.txt Outdated Show resolved Hide resolved
Chromium-XP_49_0_2623_113_VS2013_SSE3.txt Outdated Show resolved Hide resolved
Chromium-XP_49_0_2623_113_VS2013_SSE3.txt Outdated Show resolved Hide resolved
Chromium-XP_49_0_2623_113-R2_VS2015_SSE2.txt Outdated Show resolved Hide resolved
Chromium-XP_49_0_2623_113_VS2013_SSE3.txt Outdated Show resolved Hide resolved
JoachimHenze and others added 3 commits October 20, 2023 21:59
@JoachimHenze @binarymaster
Stasmify1
5dfc6d2 
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
@JoachimHenze @binarymaster
Stasmify2
9cdcd32 
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
@JoachimHenze
stasmify3, strip "on ROS" entirely.
a6a16c1
@JoachimHenze
Copy link
Contributor Author

General suggestion: Maybe simplify .txt filenames, as it would complicate installing from command-line RAPPS.

Hmm, there is tab-completion, isn't it?

@binarymaster
Copy link
Member

Hmm, there is tab-completion, isn't it?

Yes, but only when you're in RAPPS appdata directory (which usually isn't the case).

@binarymaster
Copy link
Member

Chromium-XP_49_0_2623_113_VS2013_SSE3.txt => Chromium-XP_49_SSE3.txt

Chromium-XP_49_0_2623_113-R2_VS2015_SSE2.txt => Chromium-XP_49_SSE2.txt

@JoachimHenze
Copy link
Contributor Author

JoachimHenze commented Oct 22, 2023 •
edited
Loading

No I don't like that renaming, it will revert the ordering. The SSE2-build is the newer one. How often will you install that from the command line? I doubt this so going to be to happen so often. The MyPal (and NewMoon) browsers do run much better. We will most likely installl this browser, when we do aim to improve/debug it further. Not so much for daily usage.

@binarymaster
Copy link
Member

No I don't like that renaming, it will revert the ordering.

Ordering of what? RAPPS doesn't use filenames to order the list of apps.

@JoachimHenze
Copy link
Contributor Author

No but the filesystem that contains the txt files does.

@JoachimHenze JoachimHenze merged commit d12941a into master Oct 24, 2023
@JoachimHenze JoachimHenze deleted the rapps_chromium_xp branch October 24, 2023 20:55
@binarymaster
Copy link
Member

No but the filesystem that contains the txt files does.

How this is an argument?

@JoachimHenze
Copy link
Contributor Author

Feel free to rename them with some future commits. I guess i got a bit sick about the nitpicking in here.

@FlorianisonGitHub
Copy link

FlorianisonGitHub commented Feb 18, 2024 •
edited
Loading

What about support for non-SSE2 (P-III and Althon XP) and non-SSE (P-II) processors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarymaster binarymaster binarymaster left review comments

@DarkFire01 DarkFire01 DarkFire01 approved these changes

@HBelusca HBelusca HBelusca approved these changes

Assignees

@JoachimHenze JoachimHenze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoachimHenze @binarymaster @FlorianisonGitHub @HBelusca @DarkFire01