Close stream resource if connection fails #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just rebased this on the current master now that #46 is in. Ready for review :) |
|
LGTM |
cboden
added a commit
that referenced
this pull request
Feb 23, 2016
Close stream resource if connection fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a connection attempt is being rejected, the resulting promise will successfully be rejected. However, the underlying socket resource will not be closed (and is not exposed to the outside).
This is a trivial fix for leaking these resources.
This situation is already covered by our test cases, so it does not include additional tests. We could look into counting open socket descriptors, but we'd likely have to resort to using system utilities as PHP does not appear to offer anything related.
This PR builds on top of #46, so the diff also includes its changes. Look here for changes only related to this PR alone.(no longer applies after rebasing)