Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Update test suite to avoid unhandled promise rejections #80

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[3.x] Update test suite to avoid unhandled promise rejections #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/CoroutineTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ public function testCoroutineShouldNotCreateAnyGarbageReferencesForPromiseReject
});
});

$promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection

unset($promise);

$this->assertEquals(0, gc_collect_cycles());
Expand Down Expand Up @@ -232,6 +234,8 @@ public function testCoroutineShouldNotCreateAnyGarbageReferencesWhenGeneratorThr
yield; // @phpstan-ignore-line
});

$promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection

unset($promise);

$this->assertEquals(0, gc_collect_cycles());
Expand All @@ -249,6 +253,8 @@ public function testCoroutineShouldNotCreateAnyGarbageReferencesWhenGeneratorYie
yield 42;
});

$promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection

unset($promise);

$this->assertEquals(0, gc_collect_cycles());
Expand Down