Make nullable parameters explicity nullable for PHP 8.4 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
requested changes
Dec 19, 2024
| @@ -164,7 +164,7 @@ public function __construct($cmd, $cwd = null, array $env = null, array $fds = n | |||
| * @param float $interval Interval to periodically monitor process state (seconds) | |||
| * @throws \RuntimeException If the process is already running or fails to start | |||
| */ | |||
| public function start(LoopInterface $loop = null, $interval = 0.1) | |||
| public function start(?LoopInterface $loop = null, $interval = 0.1) | |||
There was a problem hiding this comment.
Could you update this method the same way this method has been updated in another package? https://github.com/reactphp/socket/pull/318/files#diff-2c0b16424077d1ecafdbbca23aa3f137bc007241b00fe55dd536434c147326ca This way we can ensure it runs on all PHP versions in rage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly nullable parameter types are deprecated in PHP 8.4
https://www.php.net/manual/it/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter