Added a note about windows compatibility to the readme #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Jul 8, 2017
README.md
Outdated
| @@ -219,6 +220,14 @@ of the actual exit code. | |||
| **Note:** This functionality was taken from Symfony's | |||
| [Process](https://github.com/symfony/process) compoment. | |||
|
|
|||
| ### Windows Compatibility | |||
|
|
|||
| Due to the blocking nature of `STDIN`/`STDOUT`/`STDERR` pipes on windows we cannot | |||
There was a problem hiding this comment.
Uhm, shouldn't that be does not work on Windows? IIRC stream does error out if it can't set the stream to non-blocking.
clue
approved these changes
Jul 10, 2017
|
My note is hidden, but didn't get an answer.
|
|
@kelunik not on Windows, it won't error out and just stay blocking making everything hang 😞 . I'm preparing another PR that would make running on Windows a bit more feasible. |
jsor
approved these changes
Jul 10, 2017
|
@kelunik still seen it not error out while the stream blocks on an OS level while PHP sees it as blocking and there is nothing we can do about it. Also this wording suites the fact better that it does run on Windows when using WSL. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in
react/streamwe cannot guarantee native windows anymore. Added a note about it in thereadme.