Remove now unneeded buffer workaround for legacy PHP < 5.4 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code below has been introduced via #29 to work around an issue for legacy PHP < 5.4 only, but was later fixed upstream in the Stream component via reactphp/stream#80 which later landed here via #38 so that this work around is no longer needed here 👍
This is merely a code cleanup because this code is in fact no longer needed and has zero effect right now (this is covered by the tests introduced via #29). A similar (but unrelated) issue has been raised in #40 which I'd like to address separately once we try to reproduce this. For the reference: The original issue boils down to an issue in PHP itself and it's very likely we'll see something similar here: reactphp/stream#78