Support passing custom pipes and file descriptors to child process #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Dec 3, 2018
This was referenced Dec 3, 2018
This was referenced Jan 9, 2019
clue
added a commit
to clue-labs/reactphp-ssh-proxy
that referenced
this pull request
Jan 19, 2019
This fixes a possible race condition where open FDs where in fact inherited to the wrapping shell before it had a chance to close them again when it is being replaced with the actual SSH binary. This builds on top of reactphp/child-process#65
clue
added a commit
to clue-labs/reactphp-ssh-proxy
that referenced
this pull request
Jan 19, 2019
This fixes a possible race condition where open FDs where in fact inherited to the wrapping shell before it had a chance to close them again when it is being replaced with the actual SSH binary. This builds on top of reactphp/child-process#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing custom pipes and file descriptors to child processes. This is considered advanced usage and will only be used when explicitly configured during construction. Additionally, this is a prerequisite for Windows support (#9).
Builds on top of #64
Resolves / closes #12