-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reactphp/async instead of clue/reactphp-block #53
Conversation
@dinooo13 Thanks for this PR, can you add some references in your PR description similar to my comment in clue/reactphp-mq#34. |
Updated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinooo13 Changes LGTM, may I ask you to rebase/squash this into a single commit? 👍
squashed 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinooo13 Thanks for the update, keep it up!
See https://github.com/reactphp/async
Ref: clue/reactphp-block#67, clue/reactphp-block#68, reactphp/http#464 and clue/reactphp-mq#34