Add SelectiveTransportExecutor to retry with TCP if UDP is truncated and automatically select transport protocol when no explicit scheme is given in Factory #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
selective-transport
branch
2 times, most recently
from
ff630ba
to
7caee79
Compare
clue
force-pushed
the
selective-transport
branch
from
7caee79
to
994b019
Compare
WyriHaximus
approved these changes
Aug 13, 2019
jsor
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes applied, the Factory now defaults to automatically selecting the correct transport protocol in its executor-stack. It will always try to send it over the more efficient UDP transport first. If this query yields a size related issue (truncated messages), it will retry over a streaming TCP/IP transport.
It's still possible to explicitly specify the udp:// or tcp:// URI scheme in order force using only the UDP or TCP-based executor stacks respectively. This explicit choice continues to exist mostly for rare special cases and debugging purposes.
Builds on top of #145 and #146
Resolves #19