Support Socket component v0.5 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Feb 13, 2017
jsor
approved these changes
Feb 13, 2017
|
Rebased now that #45 is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support upcoming Socket v0.5 release. Socket v0.5 contains some breaking changes, but this component is actually fully compatible.
The Socket v0.5 release is not out yet, but we'll have to update this component first, because there would otherwise be no installation candidate for when Socket v0.5 tries to install DNS v0.4.* due to its circular dependency.
Ultimately, this dependency should eventually be removed via #12 and #19, but this will require a rather bigger change in the future and a potential BC break.