Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simpler internal API #49

Merged
merged 3 commits into from
Mar 2, 2017
Merged

Add simpler internal API #49

merged 3 commits into from
Mar 2, 2017

Conversation

clue
Copy link
Member

@clue clue commented Feb 13, 2017

The Executor violates SRP, so this PR is a first step to break this up into multiple independent responsibilities.

This PR preserves full BC by adding some new internal APIs first and then deprecate the existing internal API. This can also be reused for other components, in particular clue/mdns-react. Also, this is needed for upcoming changes related to #12 and #19 which will introduce new executor classes that will reuse these methods.

If you want to review, consider looking at the individual commits instead.

Refs #48.

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clue
Copy link
Member Author

clue commented Mar 2, 2017

Rebased now that #48 is in :shipit:

@clue clue merged commit cd3572a into reactphp:master Mar 2, 2017
@clue clue deleted the simpler branch March 2, 2017 18:07
@clue clue mentioned this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants