Lock minimum dependencies and work around circular dependency for tests #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have a cyclic dependency between react/socket and react/dns which causes the test setup to fail or pick outdated versions otherwise.
|
The graph seems to be missing... |
clue
changed the title
|
Sorry, accidentally hit submit while typing, post updated :-) |
|
It happens no problem 👍 |
jsor
approved these changes
Aug 9, 2017
WyriHaximus
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The react/dns package currently has a dependency on react/socket and thus has no way of knowing which version of said package is compatible with this root package version. Here's a dependency graph that shows this cyclic dependency (generated via https://github.com/clue/graph-composer):
The dependency graph highlights how Composer picks an older version of react/socket by default which does not have this dependency. Once you actively pass the root package version, Composer will actually pick the "right" version:
Note that this only affects this package when it's installed as the root package (for testing and development). Everything works without this when it's used as a normal dependency.
Refs reactphp/socket#54
Builds on top of #70.