-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support \Throwable when setting previous exception from server callback #155
Support \Throwable when setting previous exception from server callback #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting! PHP's docs actually allow a Throwable
here (checked the German docs before which seem to be outdated currently, duh).
I guess we should also mention this in our README?
Won't |
@maciejmrozinski Indeed, verified using l3v4. |
@maciejmrozinski Thanks for the clarification! Yes, with PHP5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, should this be mentioned in the README (see error
event)?
The question is rather if we should completely switch over to use |
Hit this wall too. Setting this up would mean stuff like |
I agree that we should get this in, but we should make sure this is mentioned in the README (which only mentions |
@clue Yes, and that is correct because the server will always emit a |
I think this should be mentioned in the README 👍 In particular, it currently says (emphasis mine):
|
To properly support Should we bump the version in composer.json or add a note to the readme? |
@jsor bumping sounds like a good idea to me 👍 |
🎉 |
Followup for #152