Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example 63 to support v1.0.0+ #400

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Update example 63 to support v1.0.0+ #400

merged 1 commit into from
Jan 26, 2021

Conversation

pavog
Copy link
Contributor

@pavog pavog commented Jan 6, 2021

Add LoopInterface as first constructor argument to Server and change Server to accept variadic middleware handlers instead of array.

Add LoopInterface as first constructor argument to Server and change Server to accept variadic middleware handlers instead of array.
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavog Thanks for the update, changes LGTM! :shipit:

This does indeed appear to be a small oversight from #361 / #362

@jsor jsor merged commit 538a8f4 into reactphp:master Jan 26, 2021
@pavog pavog deleted the patch-2 branch January 26, 2021 16:48
@clue clue added this to the v1.3.0 milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants