Allow Explicit content length on HEAD requests #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Mar 4, 2022
There was a problem hiding this comment.
@mrsimonbennett Thank you for filing this PR, changes LGTM!
I've reproduced this locally and can can confirm this changeset is indeed needed to give more control over the Content-Length response header for HEAD requests. This is somewhat related to #429 and #430 merged only recently.
May I ask you to squash your changes into a single commit? 👍
|
@clue done :) |
clue
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
@mrsimonbennett Thanks for the update, changes LGTM! 
Keep it up 👍
WyriHaximus
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I am in the process of building a server to site infront of S3
https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13
"The Content-Length entity-header field indicates the size of the entity-body, in decimal number of OCTETs, sent to the recipient or, in the case of the HEAD method, the size of the entity-body that would have been sent had the request been a GET."