Avoid unnecessary creation of closures when no canceller is given

reactphp · Oct 5, 2014 · 77f78d9 · 77f78d9 · mtdowling · Oct 5, 2014
1 parent d5b6f8e
commit 77f78d9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/Promise.php b/src/Promise.php
@@ -25,6 +25,10 @@ public function then(callable $onFulfilled = null, callable $onRejected = null,
             return $this->result->then($onFulfilled, $onRejected, $onProgress);
         }
 
+        if (null === $this->canceller) {
+            return new static($this->resolver($onFulfilled, $onRejected, $onProgress));
+        }
+
         $this->requiredCancelRequests++;
 
         return new static($this->resolver($onFulfilled, $onRejected, $onProgress), function ($resolve, $reject, $progress) {