Merge pull request #277 from clue-labs/php8.1

Support PHP 8.1
reactphp · Dec 6, 2021 · 894c711 · 894c711
2 parents 12a880b + 193b3cc
commit 894c711
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -31,7 +31,7 @@
         "react/dns": "^1.8",
         "react/event-loop": "^1.2",
         "react/promise": "^2.6.0 || ^1.2.1",
-        "react/promise-timer": "^1.4.0",
+        "react/promise-timer": "^1.8",
         "react/stream": "^1.2"
     },
     "require-dev": {

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -4,8 +4,9 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
          bootstrap="vendor/autoload.php"
+         cacheResult="false"
          colors="true"
-         cacheResult="false">
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="React Test Suite">
             <directory>./tests/</directory>

diff --git a/src/DnsConnector.php b/src/DnsConnector.php
@@ -23,7 +23,9 @@ public function connect($uri)
         if (\strpos($uri, '://') === false) {
             $uri = 'tcp://' . $uri;
             $parts = \parse_url($uri);
-            unset($parts['scheme']);
+            if (isset($parts['scheme'])) {
+                unset($parts['scheme']);
+            }
         } else {
             $parts = \parse_url($uri);
         }

diff --git a/src/HappyEyeBallsConnector.php b/src/HappyEyeBallsConnector.php
@@ -35,7 +35,9 @@ public function connect($uri)
         if (\strpos($uri, '://') === false) {
             $uri = 'tcp://' . $uri;
             $parts = \parse_url($uri);
-            unset($parts['scheme']);
+            if (isset($parts['scheme'])) {
+                unset($parts['scheme']);
+            }
         } else {
             $parts = \parse_url($uri);
         }