Simplify skipping DNS lookup when connecting to IP addresses

reactphp · Apr 23, 2018 · df02c39 · df02c39
1 parent d395731
commit df02c39
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/DnsConnector.php b/src/DnsConnector.php
@@ -35,6 +35,11 @@ public function connect($uri)
         $host = trim($parts['host'], '[]');
         $connector = $this->connector;
 
+        // skip DNS lookup / URI manipulation if this URI already contains an IP
+        if (false !== filter_var($host, FILTER_VALIDATE_IP)) {
+            return $connector->connect($uri);
+        }
+
         return $this
             ->resolveHostname($host)
             ->then(function ($ip) use ($connector, $host, $parts) {
@@ -86,10 +91,6 @@ public function connect($uri)
 
     private function resolveHostname($host)
     {
-        if (false !== filter_var($host, FILTER_VALIDATE_IP)) {
-            return Promise\resolve($host);
-        }
-
         $promise = $this->resolver->resolve($host);
 
         return new Promise\Promise(