Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionInterface should extend DuplexStreamInterface + documentation #50

Merged
merged 4 commits into from
Dec 19, 2016

Conversation

clue
Copy link
Member

@clue clue commented Nov 13, 2016

Make sure the ConnectionInterface actually extends the DuplexStreamInterface introduced with react/stream v0.4.2. Thus, the main difference here is this:

-interface ConnectionInterface extends ReadableStreamInterface, WritableStreamInterface
+interface ConnectionInterface extends DuplexStreamInterface

Note that this is not a BC break because the DuplexStreamInterface actually extends both ReadableStreamInterface and WritableStreamInterface.

Also update the documentation to emphasize this is the main interface that is to be used to represent incoming connections.

clue added a commit to clue-labs/socket that referenced this pull request Nov 13, 2016
@clue clue modified the milestone: v0.4.4 Nov 15, 2016
@clue clue mentioned this pull request Nov 15, 2016
@clue clue merged commit bf7b31e into reactphp:master Dec 19, 2016
@clue clue deleted the connectioninterface branch December 19, 2016 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants