Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support socket context options passed to Server #64

Merged
merged 2 commits into from
Jan 26, 2017

Conversation

clue
Copy link
Member

@clue clue commented Jan 24, 2017

Fixes / closes #59

@clue clue added this to the v0.4.6 milestone Jan 24, 2017
@clue
Copy link
Member Author

clue commented Jan 24, 2017

Updated to skip the failing test on legacy HHVM :shipit:

Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@clue
Copy link
Member Author

clue commented Jan 25, 2017

Rebased to resolve merge conflict with #63, otherwise unchanged :shipit:

@clue
Copy link
Member Author

clue commented Jan 25, 2017

Had to amend the incorrect version comparison (not sure why this worked before), but there you go :shipit:

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional socket context options
3 participants