Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and tests for exposing secure context options #69

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

clue
Copy link
Member

@clue clue commented Feb 8, 2017

Make sure underlying plaintext TCP/IP socket server exposes the correct
context options to the secure TLS socket server.

Marking this as a bug, but it is very unlikely to have caused any issues in real-world code, as this does not occur if one follows the existing documentation.
This could only really happen if one were to extend the Server class and returned custom connection instances that implement the ConnectionInterface but do not extend the Stream class.

Refs reactphp-legacy/socket-client#73

Make sure underlying plaintext TCP/IP socket server exposes the correct
context options to the secure TLS socket server.
@clue clue added this to the v0.5.0 milestone Feb 8, 2017
@WyriHaximus WyriHaximus merged commit ca73095 into reactphp:master Feb 8, 2017
@clue clue deleted the secure-connection branch February 8, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants