Documentation and tests for exposing secure context options #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure underlying plaintext TCP/IP socket server exposes the correct context options to the secure TLS socket server.
WyriHaximus
approved these changes
Feb 8, 2017
jsor
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure underlying plaintext TCP/IP socket server exposes the correct
context options to the secure TLS socket server.
Marking this as a bug, but it is very unlikely to have caused any issues in real-world code, as this does not occur if one follows the existing documentation.
This could only really happen if one were to extend the
Serverclass and returned custom connection instances that implement theConnectionInterfacebut do not extend theStream class.Refs reactphp-legacy/socket-client#73