Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom ConnectionException with generic RuntimeException #72

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

clue
Copy link
Member

@clue clue commented Feb 8, 2017

This simple PR replaces the undocumented ConnectionException with a generic RuntimeException.
Also adds some documentation for when this occurs and is now in line with other exceptions described in #60 and #61.

Extending the ErrorException doesn't really make any sense, because we never actually supported any of its properties.

This change introduces a small BC break, but I figured it's worth it because it reduces the API footprint further (refs #71 and #70) and makes sure our exception usage is consistent across this project.

Also closes #56 while we're at it :shipit:

@clue clue added this to the v0.5.0 milestone Feb 8, 2017
@clue clue merged commit 8844d47 into reactphp:master Feb 8, 2017
@clue clue deleted the exception branch February 8, 2017 13:08
clue added a commit to clue-labs/socket that referenced this pull request Mar 29, 2017
Replace SecureStream with unlimited read buffer from react/stream v0.4.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listening on same port twice does not fail on Windows
3 participants