Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward compatibility with Stream v0.5 and upcoming v0.6 #79

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Forward compatibility with Stream v0.5 and upcoming v0.6 #79

merged 1 commit into from
Mar 9, 2017

Conversation

clue
Copy link
Member

@clue clue commented Mar 8, 2017

This component is in fact already compatible with v0.4, the new v0.5 and the upcoming v0.6, see also reactphp/stream#67.

@clue clue added this to the v0.5.1 milestone Mar 8, 2017
@clue clue mentioned this pull request Mar 8, 2017
Merged
jsor
jsor requested changes Mar 8, 2017
View reviewed changes
README.md Outdated
@@ -346,6 +346,14 @@ $connection->on('data', function ($chunk) {
echo $data;
});

$conenction->on('end', function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: $conenction -> $connection

README.md Outdated
echo 'ended';
});

$conenction->on('error', function (Exception $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: $conenction -> $connection

@clue clue mentioned this pull request Mar 8, 2017
Merged
@clue
Copy link
Member Author

clue commented Mar 8, 2017

Thanks for spotting these, typos fixed and changes squashed :shipit:

@clue clue mentioned this pull request Mar 8, 2017
Merged
@WyriHaximus WyriHaximus merged commit 0b8c101 into reactphp:master Mar 9, 2017
@clue clue deleted the stream branch March 9, 2017 12:03
@clue clue mentioned this pull request Mar 22, 2017
Merged
clue added a commit to clue-labs/socket that referenced this pull request Mar 29, 2017
@clue
Merge pull request reactphp#79 from clue-labs/require-cancellation
832f6b5 
Require cancellation support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance new feature
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus