Support setting buffer size to null (infinite)

reactphp · Mar 15, 2016 · 174e718 · 174e718
1 parent 0e05d9f
commit 174e718
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/src/Stream.php b/src/Stream.php
@@ -8,7 +8,11 @@
 
 class Stream extends EventEmitter implements DuplexStreamInterface
 {
+    /**
+     * @var int|null maximum buffer size in bytes to read at once or null=infinite, until reaching EOF
+     */
     public $bufferSize = 4096;
+
     public $stream;
     protected $readable = true;
     protected $writable = true;
@@ -128,7 +132,7 @@ public function pipe(WritableStreamInterface $dest, array $options = array())
 
     public function handleData($stream)
     {
-        $data = fread($stream, $this->bufferSize);
+        $data = stream_get_contents($stream, $this->bufferSize === null ? -1 : $this->bufferSize);
 
         if ($data !== '') {
             $this->emit('data', array($data, $this));

diff --git a/tests/StreamTest.php b/tests/StreamTest.php
@@ -75,6 +75,33 @@ public function testDataEventDoesEmitOneChunkMatchingBufferSize()
         $this->assertEquals($conn->bufferSize, strlen($capturedData));
     }
 
+    /**
+     * @covers React\Stream\Stream::__construct
+     * @covers React\Stream\Stream::handleData
+     */
+    public function testDataEventDoesEmitOneChunkUntilStreamEndsWhenBufferSizeIsInfinite()
+    {
+        $stream = fopen('php://temp', 'r+');
+        $loop = $this->createLoopMock();
+
+        $capturedData = null;
+
+        $conn = new Stream($stream, $loop);
+        $conn->bufferSize = null;
+
+        $conn->on('data', function ($data) use (&$capturedData) {
+            $capturedData = $data;
+        });
+
+        fwrite($stream, str_repeat("a", 100000));
+        rewind($stream);
+
+        $conn->handleData($stream);
+
+        $this->assertFalse($conn->isReadable());
+        $this->assertEquals(100000, strlen($capturedData));
+    }
+
     /**
      * @covers React\Stream\Stream::handleData
      */