Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by prefixing all global functions calls with \ to skip the look up and resolve process and go straight to the global function #137

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Improve performance by prefixing all global functions calls with \ to skip the look up and resolve process and go straight to the global function #137

merged 1 commit into from
Oct 19, 2018

Conversation

WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Oct 18, 2018 •
edited
Loading

The performance increase measuring using examples/91-benchmark-throughput.php -t30 is as follows:

  • master: 3.0GB/s
  • This PR: 3.1GB/s
  • Raw Linux using cat /dev/zero | pv > /dev/null: 3.2GB/s

@WyriHaximus
Prefix all global functions calls with \ to skip the look up and reso…
aea4ab4 
…lve process and go straight to the global function
@WyriHaximus WyriHaximus requested review from jsor and clue October 18, 2018 21:01
@WyriHaximus WyriHaximus added this to the v1.0.1 milestone Oct 19, 2018
@clue clue modified the milestones: v1.0.1, v1.1.0 Oct 19, 2018
clue
clue approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that running the benchmark slightly improved throughput from 4706 MiB/s to 4780 MiB/s (best of five runs each) on my laptop 💪 🎉

@clue clue changed the title Prefix all global functions calls with \ to skip the look up and resolve process and go straight to the global function Improve performance by prefixing all global functions calls with \ to skip the look up and resolve process and go straight to the global function Oct 19, 2018
@clue clue merged commit f16ca72 into reactphp:master Oct 19, 2018
@WyriHaximus WyriHaximus mentioned this pull request Dec 30, 2018
Merged
This was referenced Jan 7, 2019
Merged
Merged
Merged
@clue clue mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@WyriHaximus @jsor @clue @bubach