ScrollView fails when contentInsetAdjustmentBehavior is automatic

[grahammendick]

I've started updating my navigation library to work with the new architecture and I've run into a problem on iOS. The ScrollView doesn't work when contentInsetAdjustmentBehavior is set to automatic. You can see what I mean in the video below. The first time you navigate to the second screen then the ScrollView behaves correctly. But the second time you navigate you can see that the ScrollView isn't adjusting for the navigation bar.

Reproduction of the problem

I've created a repository with a reproduction of the bug. The README in the repo contains the steps needed to recreate the problem. There are two apps in the repo, one built with the old architecture and the other built with the new architecture. You can see that the bug only happens on the new architecture. The only dependencies in the apps are the 3 packages that make up my navigation library.

Screen.Recording.2022-04-17.at.18.26.46.mov

[sammy-SC]

Thank you for the report, this looks like a bug. It seems to happen when the same instance of scroll view is reused.

@grahammendick would you be interested in creating a PR to fix this issue? I would be happy to provide code pointers.

[grahammendick]

I’m in the process of updating my Navigation router to the new architecture. I’ve already spent about 3 weeks on it and I’m not even a quarter of the way through. My library is 100% native - every component renders to its native counterpart - so the new architecture has given me a lot to rewrite and test.

Having said that, this scroll view bug is a showstopper for my Navigation router. I can’t upgrade to the new architecture without a fix for this. But I can see that, from the perspective of the React Native team, this bug might be low priority. So if the only way to ensure this gets fixed is for me to work on it then I will definitely make the time.

Please let me know what priority this bug is for the React Native team.

[dmytrorykun]

Hi @grahammendick, thank you for the reporting this bug and for the test project! We have landed a fix. It will be available in v0.69

[grahammendick]

Thank you v much! Out of interest could you point me at the fix please? I'm guessing you added something to the Scroll View's prepareForRecycle?

[dmytrorykun]

Yeah, you're right 🙂. Here it is facebook/react-native@28a65f4

[grahammendick]

Thanks 👍