Should we release 0.67.2?

[lunaleaps]

0.67.2 has been released. See discussion for 0.67.3

Conversations on this thread are limited:

• major release issues
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issue, please reference the issue here.

---

List of qualified picks

1. facebook/react-native@35bcf93
2. facebook/react-native@60cef85
3. facebook/react-native@507b05f
4. facebook/react-native@d6db5c5
5. facebook/react-native@76a2cf3
6. facebook/react-native@6239e2f

Local commits to backport to main

[zibs]

Could we cherry-pick facebook/react-native@35bcf93? Currently npx react-native init <App> (0.67.1) results in an unbuildable yarn ios for me due to this find-node.sh script exiting with a non-zero exit code during FBReactNativeSpec when building. I'm on an m1/nvm type of setup. Not sure if this is a universal issue, but this commit fixed my issue at least.

[huynextlevel]

You can try with this to fixing which node issuse

sudo ln -s $(which node) /usr/local/bin/node

[kelset]

@zibs can you verify that cherry picking the commit would solve your issue by testing the artifact as explained by this comment? facebook/react-native#32955 (comment)

[zibs]

Ah, thanks for the nudge @kelset.

It worked aside from some yarn add issues I was having...so in the end I just used npm install --save <path to tarball> and deleted my node modules, package-lock/yarn.lock and reinstalled, and everything built + rendered fine.

@huynextlevel I've tried that, but it actually didn't seem to resolve my issue in this case. The other issue with that solution as well is if I'm running multiple RN projects which use different node versions things can get messy since the symlink can be pointing to a different node than the one I intend to use I believe...

[mlazari]

I have the same error after updating from 0.66.4 to 0.67.1. Applying manually the fix from facebook/react-native@35bcf93 in node_modules/react-native/scripts/find-node.sh fixes it for me, so I think that would solve the issue.

[ken0nek]

Same.

Applying manually the fix from facebook/react-native@35bcf93 in node_modules/react-native/scripts/find-node.sh fixes it for me, so I think that would solve the issue.

This solved the issue.

[kelset]

Looks like there was a commit that broke Jest tests: facebook/react-native#32939, apparently by looking at the PR it sounds like it should have been signaled as a breaking change: facebook/react-native#32346

[lunaleaps]

How should this be handled? Are you suggesting a revert for 0.67?

[kelset]

The original author is looking into it, let's hear from him first - maybe there's a better option than just reverting. I'm not sure atm

[kelset]

PR with fix: facebook/react-native#32964

[kelset]

We need this merged & cherry-picked: facebook/react-native#32961

[tido64]

Commit: facebook/react-native@60cef85

[lunaleaps]

We should consider picking this facebook/react-native@76a2cf3 which updates our release automation to be less janky

[kelset]

we might have to cherry pick this facebook/react-native@d6db5c5 to address the CVE

[enahum]

@kelset I want to propose the inclusion of facebook/react-native#32989