Should we release 0.72.6?

[Titozzz]

Released, please refer to #91

Current Release: 0.72.5

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

Requests that didn't make it in 0.72.5

• Should we release 0.72.5? #85 (comment)
• Should we release 0.72.5? #85 (comment)
• Should we release 0.72.5? #85 (comment)
• Should we release 0.72.5? #85 (comment)
• Should we release 0.72.5? #85 (comment)
• Should we release 0.72.5? #85 (comment)

List of qualified picks

• [LOCAL] Copy hermes ruby files to hermes folder in local E2E test facebook/react-native#39575
• facebook/react-native@63884b4 Update Xcode 15 patches to be more robust
• facebook/react-native@ce39931 Fix Gemfile, setting Active support to < 7.1.0
• facebook/react-native@8b768f1 RN: Switch EventEmitter to Array.from(...)

Local commits to backport to main

[liamjones]

The last patch release had three fixes for Xcode 15 build issues. I've just noticed Cocoapods released a new version on Friday with an Xcode 15 related fix; https://github.com/CocoaPods/CocoaPods/releases/tag/1.13.0. Should the RN template Gemfile also be specifying this as a minimum version of Cocoapods now or is the fix not relevant to RN?

[lorenc-tomasz]

I think 0.72.6 should fix issues with Xcode 14. When someone uses Xcode 15 and push changes generated with pod install to projects that adds new flags:

OTHER_LDFLAGS = (
	"$(inherited)",
	"-Wl",
	"-ld_classic",
	"-Wl",
	"-ld_classic",
);

and probably _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION,

the changes are not removed when new pod install action is done with Xcode 14 (on CI) and the build fails with ld: library not found for -ld_classic.

EDIT:

On Azure DevOps new version of macOS-13 image was released with stable Xcode 15 so I can switch to new Xcode.

[cipolleschi]

This should be already the case as:

• this is the code block that decides whether to add or remove the flags.
• this is the function that adds the flag and should add them only if they are not in the list already
• this is the function that removes them. And again, it should remove the values.

We also have unit tests and I tested it manually... I'm very confused about this issue.

I'll try with a different implementation to see if it works better.

[MO-Lewis]

It's already in your "Requests that didn't make it in 0.72.5" list, but posting again for good measure:

Would be much appreciated if you could pick this:
facebook/react-native@0cdb9e6

It features an important couple of fixes which help to better support SSL Pinning within React Native. It was previously approved some years back, but had to be resubmitted again.

Thanks!

[huntie]

Resolved by facebook/react-native#39698.

[lorenc-tomasz]

Great :) Thank you :)

[huntie]

Both changes added to branch ✅

[huntie]

Done

[Titozzz]

facebook/react-native@58adc5e was picked in 72.2 and caused a regression fixed by facebook/react-native@16fc065, so we should pick it

[huntie]

Done

[joe-sam]

Can we pick
Prevent LogBox from crashing on long messages (facebook/react-native#38005)

[stianjensen]

Regression with rotation in animated values in RN0.72:
facebook/react-native@ae0d714
(explained here: facebook/react-native#36608)