Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y metadata parsing for EPUB #135

Merged
merged 7 commits into from
May 15, 2020

Conversation

JayPanoz
Copy link
Contributor

@JayPanoz JayPanoz commented Apr 28, 2020

Re #94

The aim of this new doc is to provide guidance for parsing accessibility metadata in EPUB publications.

A review is warmly welcome.

Source diff | Rich diff

@llemeurfr
Copy link
Contributor

@danielweck was also speaking about dcterms:conformsTo, let's check with him.

@JayPanoz JayPanoz requested a review from danielweck April 28, 2020 18:11
Copy link
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@mickael-menu
Copy link
Member

Is there still some work going on in this PR or we can merge it?

@JayPanoz
Copy link
Contributor Author

If I’m not mistaken, I think we’ve been waiting for a second review before merging it, as issues raised by Daniel initially have been resolved.

@mickael-menu mickael-menu merged commit 5f32529 into readium:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants