Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fuel and Kovenant dependencies #364

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

stevenzeck
Copy link
Contributor

This removes the dependencies on the Fuel and Kovenant libraries. All code that used these libraries has been removed, with all but one of the user-facing functions having previously been deprecated. The one that was not deprecated is Response.sniffMediaType.

If preferred, Fuel can go back in while we deprecate the function to give users time to update their own code. It can't be rewritten since it's an extension function of Fuel's own Response. Doing a search of "fuel sniffmediatype" here on GitHub only returned results of the toolkit itself (and people's own fork of it). Of course that doesn't cover anything outside of GitHub.

@qnga
Copy link
Contributor

qnga commented Jul 13, 2023

I would restore fuel, Response.sniffMediaType, as well as all of the other symbols that were only deprecated with a warning level so far. That's the general process for v3. As many other things, we'll be able to remove them as soon as v3 is released for the next version.

@mickael-menu
Copy link
Member

Thank you @stevenzeck for tackling this!

I would expect nobody uses this API, although the most user-friendly path would be to keep Fuel as deprecated level = ERROR and remove it completely in 3.1 as @qnga suggested.

Or maybe removing it completely but adding a mention in the migration guide would be enough?

@qnga
Copy link
Contributor

qnga commented Jul 13, 2023

That makes sense. There will be no surprise for users if we make clear in the migration guide that fuel support is removed.

Copy link
Contributor

@qnga qnga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stevenzeck, this is much appreciated 🙏

@mickael-menu mickael-menu merged commit 2d80205 into readium:v3 Jul 14, 2023
3 checks passed
@mickael-menu mickael-menu deleted the remove-fuel-kovenant branch July 14, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants