Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reading order as parameter to EPubFragment factory / constructor #376

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Add reading order as parameter to EPubFragment factory / constructor #376

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
55c4c2b
Add readingOrder as optional parameter to EPubNavigatorFragment
chrfalch Aug 18, 2023
f0e44f9
Merge branch 'develop' into feature/add-reading-order-as-parameter-to…
chrfalch Aug 29, 2023
4b09b72
CR: Updated readingOrder and readingPositions to be dependant on each…
chrfalch Aug 29, 2023
f1afa7b
CR: Removed outdated comment
chrfalch Aug 30, 2023
4ea2d0f
CR: Renamed Event.GoTo -> Event.OpenInternalLink
chrfalch Aug 30, 2023
83cab82
Reverted last commit - wrong PR
chrfalch Aug 30, 2023
4afac5b
CR: Updated readingOrder on constructor
chrfalch Aug 30, 2023
09e0b12
Fixed inversed condition - sorry
chrfalch Aug 31, 2023
758b08b
CR: Resolved constructor argument and property for readingOrder
chrfalch Aug 31, 2023
0ec982f
CR: Removed unneccessary arg
chrfalch Aug 31, 2023
a927aa5
Update readium/navigator/src/main/java/org/readium/r2/navigator/epub/…
chrfalch Aug 31, 2023
d9e6a47
CR: Fixed missing, in ctor args
chrfalch Aug 31, 2023
8705be1
CI: Lint fix
chrfalch Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions readium/navigator/src/main/java/org/readium/r2/navigator/epub/EpubNavigatorFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
package org.readium.r2.navigator.epub

import org.readium.r2.shared.ExperimentalReadiumApi
import org.readium.r2.shared.publication.Link
import org.readium.r2.shared.publication.Locator
import org.readium.r2.shared.publication.Publication
import org.readium.r2.shared.publication.epub.EpubLayout
Expand Down Expand Up @@ -37,6 +38,7 @@ class EpubNavigatorFactory(
publication.metadata.presentation.layout ?: EpubLayout.REFLOWABLE

fun createFragmentFactory(
readingOrder: List<Link> = publication.readingOrder,
initialLocator: Locator?,
initialPreferences: EpubPreferences = EpubPreferences(),
listener: EpubNavigatorFragment.Listener? = null,
Expand All @@ -45,6 +47,7 @@ class EpubNavigatorFactory(
) = org.readium.r2.navigator.util.createFragmentFactory {
EpubNavigatorFragment(
publication = publication,
readingOrder = readingOrder,
baseUrl = null,
initialLocator = initialLocator,
initialPreferences = initialPreferences,
Expand Down
16 changes: 10 additions & 6 deletions readium/navigator/src/main/java/org/readium/r2/navigator/epub/EpubNavigatorFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ typealias JavascriptInterfaceFactory = (resource: Link) -> Any?
@OptIn(ExperimentalDecorator::class, ExperimentalReadiumApi::class, DelicateReadiumApi::class)
class EpubNavigatorFragment internal constructor(
override val publication: Publication,
private val readingOrder: List<Link>,
private val baseUrl: String?,
private val initialLocator: Locator?,
private val initialPreferences: EpubPreferences,
Expand Down Expand Up @@ -306,13 +307,15 @@ class EpubNavigatorFragment internal constructor(
_binding = ActivityR2ViewpagerBinding.inflate(inflater, container, false)
val view = binding.root

// FIXME: If readingOrder is provided as input to the fragment, we might not want
// to map through the publication's readingOrder:
positionsByReadingOrder = runBlocking { publication.positionsByReadingOrder() }
positions = positionsByReadingOrder.flatten()
publicationIdentifier = publication.metadata.identifier ?: publication.metadata.title
mickael-menu marked this conversation as resolved.
Show resolved Hide resolved

when (viewModel.layout) {
EpubLayout.REFLOWABLE -> {
resourcesSingle = publication.readingOrder.mapIndexed { index, link ->
resourcesSingle = readingOrder.mapIndexed { index, link ->
PageResource.EpubReflowable(
link = link,
url = viewModel.urlTo(link),
Expand All @@ -329,7 +332,7 @@ class EpubNavigatorFragment internal constructor(
var doublePageLeft: Link? = null
var doublePageRight: Link? = null

for ((index, link) in publication.readingOrder.withIndex()) {
for ((index, link) in readingOrder.withIndex()) {
val url = viewModel.urlTo(link)
resourcesSingle.add(PageResource.EpubFxl(leftLink = link, leftUrl = url))

Expand Down Expand Up @@ -881,7 +884,7 @@ class EpubNavigatorFragment internal constructor(
locatorToResourceAtIndex(resourcePager.currentItem + 1)

private fun locatorToResourceAtIndex(index: Int): Locator? =
publication.readingOrder.getOrNull(index)
readingOrder.getOrNull(index)
?.let { publication.locatorFromLink(it) }

private val r2PagerAdapter: R2PagerAdapter?
Expand Down Expand Up @@ -919,7 +922,7 @@ class EpubNavigatorFragment internal constructor(
override val currentLocator: StateFlow<Locator> get() = _currentLocator
private val _currentLocator = MutableStateFlow(
initialLocator
?: requireNotNull(publication.locatorFromLink(publication.readingOrder.first()))
?: requireNotNull(publication.locatorFromLink(readingOrder.first()))
)

/**
Expand All @@ -930,7 +933,7 @@ class EpubNavigatorFragment internal constructor(
override suspend fun firstVisibleElementLocator(): Locator? {
if (!::resourcePager.isInitialized) return null

val resource = publication.readingOrder[resourcePager.currentItem]
val resource = readingOrder[resourcePager.currentItem]
return currentReflowablePageFragment?.webView?.findFirstVisibleLocator()
?.copy(
href = resource.href,
Expand Down Expand Up @@ -1040,6 +1043,7 @@ class EpubNavigatorFragment internal constructor(
*/
fun createFactory(
publication: Publication,
readingOrder: List<Link> = publication.readingOrder,
baseUrl: String? = null,
initialLocator: Locator? = null,
listener: Listener? = null,
Expand All @@ -1049,7 +1053,7 @@ class EpubNavigatorFragment internal constructor(
): FragmentFactory =
createFragmentFactory {
EpubNavigatorFragment(
publication, baseUrl, initialLocator, initialPreferences,
publication, readingOrder, baseUrl, initialLocator, initialPreferences,
listener, paginationListener,
epubLayout = publication.metadata.presentation.layout ?: EpubLayout.REFLOWABLE,
defaults = EpubDefaults(),
Expand Down
Loading