Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify RWPM parsing for packaged publications #380

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Simplify RWPM parsing for packaged publications #380

merged 4 commits into from
Aug 23, 2023

Conversation

mickael-menu
Copy link
Member

  • Don't remove the self link anymore, when parsing a packaged publication. They are not supposed to contain a self link with an absolute URL.
  • Fix file extensions in the LCP service.
  • Restore visibility of MediaSessionNavigator properties (hiding them was a mistake when migrating to the explicit API mode).

@mickael-menu mickael-menu requested a review from qnga August 23, 2023 13:25
@qnga
Copy link
Contributor

qnga commented Aug 23, 2023

You can now revert the change in ParserAssetFactory and use again asset.resource instead of the parsed manifest.

@qnga qnga merged commit f5cd4b9 into v3 Aug 23, 2023
3 checks passed
@qnga qnga deleted the various-fixes branch August 23, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qnga qnga qnga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickael-menu @qnga