This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Remove dependency to the private LCP library (R2LCPClient.framework) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix readium/swift-toolkit#152
R2LCPClient.framework, which means:r2-lcp-swiftworks as a Carthage dependency, no need to use a submodule anymore.r2-lcp-swift'sCartfileanymore to add the privateliblcpdependency.LCPService(see README for an example implementation).Note: In the future it could be possible to use reflection to avoid using a facade, but it needs some changes in
R2LCPClient.frameworkso unlikely to be done soon. For example, global functions are not reachable with reflection.