This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Check hashed passphrase returned by LCPAuthenticating #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the test-app only had a hashed version of a passphrase, it could not send it through
LCPAuthenticating
.This PR allows to provide both hashed and clear passphrases.
With this, it would be possible to implement retrieving the passphrases using Authentication for OPDS (as defined here: https://readium.org/lcp-specs/notes/lcp-key-retrieval.html) by creating a
OPDSLCPAuthentication
class implementingLCPAuthenticating
.You can also create a simple
LCPAuthenticating
implementation to provide a raw clean or hashed passphrase. The fallback is used, for example, to revert on showing a credentials pop-up if the passphrase was wrong.