This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Simplify Readium CSS injection and remove injection of the default stylesheet #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove injection of Readium's default stylesheet
mickael-menu
force-pushed
the
fix/upgrade-readium-css
branch
from
c6cb3fc
to
06756c0
Compare
Simplify serving files from the application's assets
mickael-menu
force-pushed
the
fix/upgrade-readium-css
branch
from
06756c0
to
1441cc7
Compare
qnga
reviewed
Jun 1, 2020
| import java.util.* | ||
|
|
||
| class Server(port: Int) : AbstractServer(port) | ||
| class Server(port: Int, context: Context) : AbstractServer(port, context.applicationContext) |
There was a problem hiding this comment.
This is a breaking change, isn't it?
There was a problem hiding this comment.
Yes, but a necessary one unfortunately. We need the Context to access assets which used to be passed to each injection API. I think it's cleaner that way.
Also the migration will be pretty straightforward in reading apps, the compiler will crash on the missing context.
r2-streamer/src/main/java/org/readium/r2/streamer/server/handler/AssetHandler.kt
Show resolved
Hide resolved
r2-streamer/src/main/java/org/readium/r2/streamer/server/handler/FileHandler.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address this issue by removing the injection of the default stylesheet altogether, until we add a heuristic to determine if a publication has styles.