This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Removed 'application' element from AndroidManifest.xml. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library manifest had defined the attributes 'allowBackup' and 'supportsRtl'. This may result in a manifest merge error requiring implementors to use an override like 'tools:replace'.
|
Thanks for your contribution. It seems to be a pretty common issue caused by Android Studio's default manifest for libraries: |
|
@twaddington I'm ready to merge these PRs, but first I want to confirm something with you: You didn't push a PR with this fix for |
Yep! Looks like I missed that one. There are a lot of repos 😂 Happy to put up a PR for the navigator today too. |
|
@twaddington Thanks! I'll merge the other ones in the meantimes. |
mickael-menu
approved these changes
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library manifest had defined the attributes 'allowBackup'
and 'supportsRtl'. This may result in a manifest merge error
requiring implementors to use an override like 'tools:replace'.