Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
In a Japanese Windows environment in Thorium Reader, I will change the font-family to be applied preferentially from MS Font to BIZ UD font.
To do this, I did the following:
@font-face
in this file.@font-face
in this file, but the Japanese setting is necessary for older environments such as Internet Explorer and should not be necessary in modern environments. Therefore, I removed as many settings with font names using Japanese as possible.At that time, the priority order in the Windows settings was BIZ UD, Yu, and MS fonts. (All of these fonts are installed by default in recent Windows.)
What is the current behaviour? (You can also link to an open issue here)
When using the current Thorium Reader on Windows, if you apply each font in "Extra variables for Japanese font-stacks" in the text font settings that can be set after changing the UI language to "Japanese", it will become an MS font. MS fonts are a bit rough, so I think the reading experience using this font is a bit subtle.
ex. edrlab/thorium-reader#2353 (comment)
What is the new behaviour?
I changed the font name settings in various ways, but the behavior change should only apply to Windows. And in Thorium Reader, it should be displayed in BIZ UD font with anti-aliasing enabled.
ex. edrlab/thorium-reader#2252 (comment)
(I haven't confirmed that Thorium works on macOS.)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
I don't think it will be a problem in the app.
Other information:
Some people think that Yu fonts are better than BIZ UD fonts, so it's a bit difficult to decide whether to prioritize BIZ UD (BIZ UD has less space after punctuation marks).
However, in this pull request, I chose the BIZ UD font, which is displayed clearly, because the default Yu font on Windows is displayed a little thin.
Therefore, I may choose to change the priority font order in the future.
Example of Yu/BIZ UD display in Chrome browser (image attached): https://codepen.io/peaceroad/pen/dyEOVdr
One thing to note in particular is that in vertical writing mode using the BIZ UD font, half-width ASCII characters are displayed narrowly, so if you look at only this part, the Yu font may be slightly easier to read. (Looking at this issue alone, it can be avoided by changing the setting from BIZ UD to BIZ UDP, but I didn't know if that was a good idea, so I didn't do that.)
Also, since I don't usually use macOS, there may be a better setting.