Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #38

Merged
merged 1 commit into from
May 2, 2018
Merged

fix typos #38

merged 1 commit into from
May 2, 2018

Conversation

innovimax
Copy link
Contributor

@innovimax innovimax commented Apr 27, 2018

Please check if the PR fulfills these requirements:

(Add x between brackets to check.)

  • I’ve read contributing guidelines
  • I’ve signed and sent the Readium ICLA
  • I’m making this pull request against the develop branch
  • I’ve updated from the develop branch before proposing this pull request
  • I’ve tested the changes for bug fixes and/or features
  • I’ve documented new code

What kind of change does this PR introduce? (Bug fix, feature, docs update, other)

DOC UPDATE

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@JayPanoz
Copy link
Collaborator

@llemeurfr Quick question: for such PRs (e.g. typos, docs, etc.), do we really need the Readium ICLA signed and sent? Or is it just for code?

@llemeurfr
Copy link
Contributor

llemeurfr commented Apr 30, 2018

CSS authoring and documentation authoring must get the same level of IP consideration than code.
But for typo corrections we can get a lighter way of handling things. As this PR only covers typos, I agree that signing the ICLA is not needed.

@JayPanoz
Copy link
Collaborator

JayPanoz commented May 1, 2018

Ok, since it’s a very minor change to the github template (i.e. administrative), unless someone disagrees, I think we can make an exception and merge the PR into the master branch – besides the corrected template would not be updated if it were merged into develop and would require another one from develop to master.

I’m also going to commit the updated template to the contributing guidelines in the master branch directly (and reflect handling of the ICLA for typos). Then sync the develop branch.

@JayPanoz JayPanoz merged commit 4522720 into readium:master May 2, 2018
@JayPanoz
Copy link
Collaborator

JayPanoz commented May 2, 2018

Thanks for catching those typos, @innovimax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants