Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calibre and Kindle meta in Compat doc #48

Merged
merged 3 commits into from
May 16, 2018
Merged

Add Calibre and Kindle meta in Compat doc #48

merged 3 commits into from
May 16, 2018

Conversation

JayPanoz
Copy link
Collaborator

@HadrienGardeur Could you please review the Calibre’s title_sort addition starting line 118? I’ve found lots of conflicting information so I’m not sure everything is covered there.

@JayPanoz
Copy link
Collaborator Author

OK, as per Hadrien’s suggestion, pinging @kovidgoyal for this title_sort addition: https://github.com/readium/readium-css/blob/9e2408c0f58bee08ae395843664a70563d26803d/docs/CSS21-epub_compat.md#title-sort

Is this correct? Are we missing something?

Context: We will support such useful metadata in Readium 2 so we’d better get details right. The dedicated issue is open here: readium/architecture#70

@JayPanoz JayPanoz removed the request for review from HadrienGardeur May 15, 2018 12:49
@kovidgoyal
Copy link

Yes, that is correct. Note that in calibre series_index can be a floating point number with up to two digits of precision, for example 1.01 and the values of zero and negative numbers are allowed.

Rating in calibre is always an integer between 0 and 10, where 0 is unrated and 10 is 100% (displayed as five stars in calibre). In theory odd numbers such as 1 and 3 could display as half stars, but that is not currently implemented.

@JayPanoz
Copy link
Collaborator Author

@kovidgoyal Thanks! Very much appreciated.

I’ll add those extra details ASAP tomorrow morning.

@JayPanoz JayPanoz merged commit 75747d5 into master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants