-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getWidthFactor() tests the wrong value for synthetic spread #105
Comments
Addressed in "textWidthMargins" feature branch (code in readium-share-js so native launchers also work): |
This was referenced Aug 7, 2014
Fixed by Pull Request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
getWidthFactor() tests readerSettings.syntheticSpread for "double", but does not take into account the default case "auto" as per the synthetic spread decision grid:
http://docs.google.com/spreadsheet/ccc?key=0AoPMUkQhc4wcdDI0anFvWm96N0xRT184ZE96MXFRdFE&usp=drive_web#gid=0
Which is implemented here:
https://github.com/readium/readium-shared-js/blob/develop/js/helpers.js#L207
This results in the value of left/right spacing changing when switching from auto to double, yet in both cases the reader is in synthetic spread view.
getWidthFactor():
https://github.com/readium/readium-js-viewer/blob/develop/lib/ReaderSettingsDialog.js#L27
Related issue: #103
The text was updated successfully, but these errors were encountered: