Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chai-as-promised latest version dependency on chai@>= 2.1.2 < 4 breaks build #623

Closed
hotTea opened this issue May 26, 2017 · 3 comments
Closed

Comments

@hotTea
Copy link

hotTea commented May 26, 2017

This issue is a Bug

Expected Behaviour

npm run prepare:all should not give any errors

Observed behaviour

npm run prepare:all gives following errors:

npm ERR! Linux 4.4.0-78-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.4.5
npm ERR! npm v2.15.5
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package chai@4.0.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer chai-as-promised@6.0.0 wants chai@>= 2.1.2 < 4

Steps to reproduce

  1. checkout develop branch
    git clone --recursive -b develop https://github.com/readium/readium-js-viewer.git readium-js-viewer
  2. cd readium-js-viewer
  3. git submodule update --init --recursive
  4. npm run prepare:all

Product

  • Readium cloud reader app

Additional information

"chai" 4.0.0 was just released - https://github.com/chaijs/chai/releases/tag/4.0.0. chai-as-promised's latest version (https://github.com/domenic/chai-as-promised/blob/v6.0.0/package.json) has dependency defined as ""chai": ">= 2.1.2 < 4"". Since readium-viewers's chai dependency is "latest", above dependency chain fails.

@hotTea hotTea changed the title chai-as-promised latest version dependency on chai@>= 2.1.2 < 4 chai-as-promised latest version dependency on chai@>= 2.1.2 < 4 breaks build May 26, 2017
@danielweck
Copy link
Member

Ah, yes:
chaijs/chai-as-promised#184

I am fixing this...

@danielweck
Copy link
Member

Issue addressed here: 4032f1e

@hotTea
Copy link
Author

hotTea commented May 28, 2017

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants