Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blank data for non-smilled spine items #20

Closed
wants to merge 1 commit into from
Closed

Adding blank data for non-smilled spine items #20

wants to merge 1 commit into from

Conversation

yuriyp
Copy link
Contributor

@yuriyp yuriyp commented Feb 3, 2014

No description provided.

@danielweck
Copy link
Member

Thank you, I will be using your code, but I will probably move it to SmilDocumentParser.js, as I am fixing a more critical parsing bug there.

See my related message, sent earlier today:
"
I was running tests against the MO EPUB file 120 from
epub-testsuite ( https://github.com/mgylling/epub-testsuite/tree/master/content/30/epub30-test-0120 ), and a specific fail caught my attention. I looked at
the parsing code ( https://github.com/readium/readium-js/blob/develop/epub-modules/epub/src/models/smil_document_parser.js#L134 ), and realised that the generated sequence of SMIL
data is incorrectly based on the order of manifest items (instead of
the spine).
"

Daniel

@danielweck danielweck closed this Feb 3, 2014
danielweck added a commit that referenced this pull request Feb 3, 2014
…ort for "blank" MO pages (thank you Yuriy! see issue #20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants