Fix Firefox XML namespace handling incompatibilities in package document parser #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent parser by using getElementsByTagNameNS() instead of jQuery selectors that behave differently on WebKit than on other engines.
bormind
added a commit
that referenced
this pull request
Mar 24, 2014
…nt-parsing Fix Firefox XML namespace handling incompatibilities in package document parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When working on the readium-js data model, I've discovered a bug on non-WebKit browsers. On WebKit, jQuery selectors against XML DOM work without regard for XML namespaces. On the other hand, other engines do the opposite - they won't match an element if in the original document it's physically prefixed with a namespace prefix. In such a case, they require matching against the full element name (prefix:localName), which is not portable (the used prefix can change from document to document).
My partial fix (more complex jQuery selectors still need conversion, as noted in the TODO comment) is to use the getElementsByTagNameNS() function, with a "*" namespace wildcard, based on information from this article: http://wiki.orbeon.com/forms/doc/contributor-guide/browser#TOC-Get-elements-with-prefixes.
This approach should also work for IE9 and IE10 (but not for IE <= 8).